Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regularize select statement rendering #1461

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Regularize select statement rendering #1461

merged 1 commit into from
Oct 21, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Oct 15, 2024

  • This PR regularizes the handling of different sections in DefaultSqlQueryPlanRenderer.visit_select_statement_node to have a consistent pattern for the different sections.
  • Each section calls a separate method to render that section, and each of those methods return the same result object.
  • There are no significant logic changes.
  • This makes it cleaner to add the rendering for CTEs in a later PR.

Base automatically changed from p--cte--02 to main October 17, 2024 16:05
@plypaul plypaul merged commit b1296d9 into main Oct 21, 2024
11 checks passed
@plypaul plypaul deleted the p--cte--03 branch October 21, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants