Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Mergeable for SqlBindParameterSet #1460

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Implement Mergeable for SqlBindParameterSet #1460

merged 1 commit into from
Oct 17, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Oct 15, 2024

SqlBindParameterSet implements combine(), which is similar to the interface for Mergeable objects. This PR updates SqlBindParameterSet to be a subclass of Mergeable for consistency and the ability to use convenience methods for Mergeable objects in later PRs.

@cla-bot cla-bot bot added the cla:yes label Oct 15, 2024
@plypaul plypaul marked this pull request as ready for review October 15, 2024 18:41
WilliamDee
WilliamDee approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@WilliamDee WilliamDee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL! I just added the WhereFilterSpecSet that had merge but was unaware of this Mergeable class

Base automatically changed from p--cte--01 to main October 16, 2024 18:38
@plypaul plypaul merged commit 29e2a10 into main Oct 17, 2024
11 checks passed
@plypaul plypaul deleted the p--cte--02 branch October 17, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamDee WilliamDee WilliamDee approved these changes

Assignees
No one assigned
Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plypaul @WilliamDee