Update use cases of fuctools.lru_cache to use LruCache
#1449
Conversation
plypaul
force-pushed
the
p--short-term-perf--23
branch
from
0c254f2 to
33b1a10
Compare
plypaul
force-pushed
the
p--short-term-perf--24
branch
from
bfebff1 to
c63aa58
Compare
| if result is not None: | ||
| return result | ||
|
|
||
| result = self._linkable_spec_resolver.get_linkable_elements_for_metrics( |
There was a problem hiding this comment.
There is an issue in the linkable spec resolver related to this, and I want to make sure we're not encountering it here. get_linkable_elements_for_metrics() returns a different result than get_linkable_elements_for_measures(). But the measures method is the one that is actually used in queries to resolve specs for metrics. the metrics method is only used in metadata queries (i.e., list dimensions). There are minor differences between the two results, the main one I can think of being the date part restriction for cumulative metrics. I haven't had time to dig into that bug but we should make sure we're using the correct logic for this call.
It probably doesn't impact this logic, but would be good to double check.
There was a problem hiding this comment.
Yeah, this change should not be affected by that issue.
plypaul
force-pushed
the
p--short-term-perf--23
branch
from
33b1a10 to
8d704e1
Compare
plypaul
force-pushed
the
p--short-term-perf--24
branch
from
c63aa58 to
3db62a7
Compare
plypaul
force-pushed
the
p--short-term-perf--23
branch
2 times, most recently
from
8829989 to
a3d5d63
Compare
plypaul
force-pushed
the
p--short-term-perf--24
branch
from
3db62a7 to
4ecc0f6
Compare
plypaul
force-pushed
the
p--short-term-perf--24
branch
from
4ecc0f6 to
b63c92e
Compare
To address potential memory leaks, PR updates use cases of
functools.lru_cacheto useLruCache.