Consolidate property filters into a class #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
approved these changes
Oct 2, 2024
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class LinkableElementFilter(Mergeable): |
There was a problem hiding this comment.
Should we call this LinkableElementPropertyFilter? On first glance I would have assumed this is referring to a filter on a group by spec or something similar to that.
There was a problem hiding this comment.
This actually gets updated in a later PR to filter by element name, so I kept this more general.
plypaul
force-pushed
the
p--short-term-perf--16
branch
from
cf2796e to
f7e3c05
Compare
courtneyholcomb
pushed a commit
that referenced
this pull request
Oct 9, 2024
The signature of a few functions in `ValidLinkableSpecResolver` take in a few arguments that describe how to filter the returned items based on properties. To simplify the signatures and enable improved caching in a later PR, this PR groups them into the `LinkableElementFilter` class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of a few functions in
ValidLinkableSpecResolvertake in a few arguments that describe how to filter the returned items based on properties. To simplify the signatures and enable improved caching in a later PR, this PR groups them into theLinkableElementFilterclass.