Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache SemanticModelLookup.get_defined_time_granularity() #1437

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Oct 1, 2024

The defined time granularity of a time dimension is frequently called during query resolution to figure out the time granularity for an ambiguous group-by item.

@cla-bot cla-bot bot added the cla:yes label Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@plypaul plypaul force-pushed the p--short-term-perf--11 branch from bfc147b to 25b2feb Compare October 1, 2024 00:16
@plypaul plypaul force-pushed the p--short-term-perf--12 branch from 0498d82 to ad2e215 Compare October 1, 2024 00:16
@plypaul plypaul force-pushed the p--short-term-perf--11 branch from 25b2feb to 5661218 Compare October 1, 2024 00:22
@plypaul plypaul force-pushed the p--short-term-perf--12 branch from ad2e215 to 9468474 Compare October 1, 2024 00:22
@plypaul plypaul force-pushed the p--short-term-perf--11 branch from 5661218 to 11e5c4e Compare October 1, 2024 00:26
@plypaul plypaul force-pushed the p--short-term-perf--12 branch from 9468474 to 68c777a Compare October 1, 2024 00:26
@plypaul plypaul marked this pull request as ready for review October 1, 2024 00:30
Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@plypaul plypaul force-pushed the p--short-term-perf--11 branch from 11e5c4e to bbe7a02 Compare October 2, 2024 05:34
Base automatically changed from p--short-term-perf--11 to main October 2, 2024 05:37
@plypaul plypaul force-pushed the p--short-term-perf--12 branch from 68c777a to 3493791 Compare October 2, 2024 06:39
@plypaul plypaul merged commit d507cfe into main Oct 2, 2024
10 checks passed
@plypaul plypaul deleted the p--short-term-perf--12 branch October 2, 2024 06:49
courtneyholcomb pushed a commit that referenced this pull request Oct 9, 2024
The defined time granularity of a time dimension is frequently called
during query resolution to figure out the time granularity for an
ambiguous group-by item.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants