Upgrade DSI #1433
Merged
Upgrade DSI #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serramatutu
approved these changes
Sep 30, 2024
DevonFulcher
approved these changes
Sep 30, 2024
courtneyholcomb
added a commit
that referenced
this pull request
Oct 9, 2024
Upgrade DSI in MF. This is blocking mantle from release currently. I made a change to dbt-core on Friday to pin core to DSI 0.7.2. This went through without issue. But when trying to sync that change to mantle, we ran into a version conflict with metricflow-semantics (which is only a dependency in mantle, not core), since was pinned to a metricfllow commit SHA that uses a lower version of DSI. Here I am upgrading the dependency in metricflow-semantics to match DSI 0.7.2 at minimum, or any other higher version that is non-breaking. This will allow us to continue developing in core using new DSI versions without having to change the metricflow-semantics commit SHA in mantle every time. Once this commit merges, I will need to make a change to mantle to point to this commit's SHA. Note that the only change in the new version is adding new validations, which won't impact MF at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade DSI in MF.
This is blocking mantle from release currently. I made a change to dbt-core on Friday to pin core to DSI 0.7.2. This went through without issue. But when trying to sync that change to mantle, we ran into a version conflict with metricflow-semantics (which is only a dependency in mantle, not core), since was pinned to a metricfllow commit SHA that uses a lower version of DSI. Here I am upgrading the dependency in metricflow-semantics to match DSI 0.7.2 at minimum, or any other higher version that is non-breaking. This will allow us to continue developing in core using new DSI versions without having to change the metricflow-semantics commit SHA in mantle every time.
Once this commit merges, I will need to make a change to mantle to point to this commit's SHA.
Note that the only change in the new version is adding new validations, which won't impact MF at all.