Bug fix: custom granularity join column gets pruned #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
changed the title
courtneyholcomb
changed the title
courtneyholcomb
force-pushed
the
court/custom-grain-where-1
branch
from
4da3888 to
5ef7eb6
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
courtneyholcomb
force-pushed
the
court/parse-custom-4
branch
from
454411e to
deccccb
Compare
github-actions
bot
removed
the
Run Tests With Other SQL Engines
courtneyholcomb
requested review from
tlento,
plypaul,
WilliamDee and
theyostalservice
WilliamDee
approved these changes
Sep 25, 2024
| metric_specs=(MetricSpec("listings"),), | ||
| time_dimension_specs=( | ||
| metric_time_with_custom_grain, | ||
| TimeDimensionSpec( |
There was a problem hiding this comment.
Do you think we need a test that has martian_day and metric_time__day since that is what is used for the time spine join? Or does this case sufficiently test that already
metricflow-semantics/metricflow_semantics/naming/dunder_scheme.py
Outdated
Show resolved
Hide resolved
metricflow-semantics/metricflow_semantics/specs/patterns/minimum_time_grain.py
Outdated
Show resolved
Hide resolved
courtneyholcomb
force-pushed
the
court/custom-grain-where-1
branch
from
5ff504b to
f52621f
Compare
…e column gets pruned
courtneyholcomb
force-pushed
the
court/custom-grain-where-1
branch
from
f52621f to
e0ea989
Compare
courtneyholcomb
added a commit
that referenced
this pull request
Sep 26, 2024
Implements some small PR feedback from #1425.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an issue with the
SqlColumnPrunerwhere it might prune a column that's used in the join condition, if it's not used anywhere else. There isn't a simple way to fix that issue in the optimizer itself, since the join condition can contain anySqlExpressionNode, and this appears to only be relevant for the new custom granularity node. Thus, I've fixed this in the custom granularity node instead of the optimizer by rendering the column's expression in the join condition instead of its alias.