Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spec patterns to filter based on linkable element properties #1421

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Sep 24, 2024

This PR adds a mechanism to allow spec patterns to filter out group-by-items based on LinkableElementProperty. Currently, this is used to only filter out group-by metrics since there can be a lot of them, but this can be extended to the other properties.

@cla-bot cla-bot bot added the cla:yes label Sep 24, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@plypaul plypaul marked this pull request as ready for review September 24, 2024 18:09
Base automatically changed from p--short-term-perf--03 to main September 24, 2024 20:42
@plypaul plypaul force-pushed the p--short-term-perf--04 branch from 140e51f to 850878b Compare September 24, 2024 20:43
@plypaul plypaul merged commit d5c0295 into main Sep 24, 2024
15 checks passed
@plypaul plypaul deleted the p--short-term-perf--04 branch September 24, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants