Change log calls to use LazyFormat and DEBUG level
#1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
plypaul
force-pushed
the
p--short-term-perf--02
branch
from
ea66615 to
4a803fb
Compare
plypaul
force-pushed
the
p--short-term-perf--03
branch
from
21421a9 to
bf28fa1
Compare
plypaul
force-pushed
the
p--short-term-perf--03
branch
from
bf28fa1 to
229d34b
Compare
courtneyholcomb
approved these changes
Sep 24, 2024
| @@ -177,14 +183,15 @@ def execute( | |||
| ) | |||
| start = time.time() | |||
| request_id = SqlRequestId(f"mf_rid__{random_id()}") | |||
| logger.info(AdapterBackedSqlClient._format_run_query_log_message(stmt, sql_bind_parameters)) | |||
| logger.info(LazyFormat("Running query", statement=stmt, param_dict=sql_bind_parameters.param_dict)) | |||
There was a problem hiding this comment.
Can we differentiate the log message for execute from query? Makes it harder to figure out where a log is coming from if the message is logged in multiple places!
plypaul
force-pushed
the
p--short-term-perf--03
branch
from
229d34b to
70dcf64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1490
As per #1419, this PR updates log calls to lazily evaluate the arguments, and changes most of them to the
DEBUGlevel. This way, performance in production will be improved if the log level is set toINFOor higher.