SQL rendering tests for metric queries with custom granularity #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-6
branch
from
889ba84 to
728e2c8
Compare
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-7
branch
2 times, most recently
from
ebb64c0 to
7ce16d1
Compare
courtneyholcomb
changed the title
courtneyholcomb
changed the title
courtneyholcomb
changed the title
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-6
branch
from
728e2c8 to
3ed4cbc
Compare
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-7
branch
from
7ce16d1 to
24d77fd
Compare
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-6
branch
from
3ed4cbc to
85f96c1
Compare
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-7
branch
2 times, most recently
from
bd5d6b1 to
c6b4526
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
tlento
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
LGTM! One note - we need to explicitly test all the time spine/fill nulls scenarios, and maybe some offset metrics, but I assume the former is not implemented yet and the latter might be more valuable as part of a test suite when we begin supporting custom granularity windows. The base case (like with cumulative) might be nice to have from the beginning, though.
courtneyholcomb
added a commit
that referenced
this pull request
Sep 24, 2024
Render SQL for custom granularities. The `JoinToCustomGranularityNode` will build a time spine dataset and `LEFT OUTER JOIN` it to the parent dataset, without a subquery. This is done by joining the time spine table directly, instead of creating a subquery that selects from the time spine table and then joins. That makes this the first node that does not create its own subquery. This join should be safe to do without a subquery since it is always a `LEFT OUTER JOIN`, ensuring the number of rows will not be changed by the join, making it relatively safe for optimizers to handle. This behavior was discussed with @tlento and agreed upon in order to ensure optimization and readability. You can see examples of what this SQL will look like in a [testing PR](#1410) higher up the stack.
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-6
branch
from
3050414 to
704e79a
Compare
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-7
branch
from
c6b4526 to
daf40f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL rendering tests for querying metrics with custom granularities. Does not include tests with filters (coming later). If you have suggestions for additional metric scenarios that should be tested, please let me know!