TimeSpineSource additions & rename SqlTableFromClauseNode -> SqlTableNode
#1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/custom-grain-dfp1
branch
from
d8ee7c8 to
ed8bc19
Compare
Previously, we were never rendering a join with only a table (no subquery), but that will change for custom granularities. Those joins will use this node, which essentially just renders a table name and alias. I've renamed the node to reflect that change.
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-2
branch
from
1f593a4 to
a064583
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More setup that will be used for rendering custom granularity SQL.
Previously, we were never rendering a join with only a table (no subquery), but that will change for custom granularities. Those joins will use this node, which essentially just renders a table name and alias. I've renamed the node to reflect that change.
Also adds some functionality to
TimeSpineSourcethat will be needed soon.