Lowercase all names passed into StructuredLinkableSpecName
#1394
Conversation
There was a problem hiding this comment.
I'm approving to unblock the various cross-repo wrangling we're trying to get in place, but this change needs a follow-up as it introduces a bunch of subtle issues with this class that will crop up over time. It's up to you whether to do this before merge or separately.
| self.element_name = element_name.lower() | ||
| self.time_granularity_name = time_granularity_name.lower() if time_granularity_name else None | ||
| self.date_part = date_part | ||
|
|
||
| def __post_init__(self) -> None: |
There was a problem hiding this comment.
This is a dataclass construct and will no longer be called. Let's merge the remaining bits into __init__ and then remove this method.
There was a problem hiding this comment.
Oooh TIL!! I thought this applied to all Python classes!
| @@ -29,6 +27,18 @@ class StructuredLinkableSpecName: | |||
| time_granularity_name: Optional[str] = None | |||
| date_part: Optional[DatePart] = None | |||
There was a problem hiding this comment.
Let's remove these and define property accessor methods instead.
There was a problem hiding this comment.
Oops that was just an oversight 🤦♀️ We shouldn't need to add property methods, having public attributes in the init should cover it.
|
Actually ignore the enum validation stuff and just delete post init. I found out how to verify enum structure so we'll fix that in DSI. |
Per title - lowercase all inputs to avoid errors later.