Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foundations for custom granularity #1388

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Foundations for custom granularity #1388

merged 6 commits into from
Sep 10, 2024

Conversation

courtneyholcomb
Copy link
Contributor

A few small changes that will be used in the dataflow plan for custom granularities. Mostly some small cleanup items (detailed in commit messages). Also adds a custom granularity called martian_day to the daily time spine. This increments one day for every thousand days. Not my decision. That's just how the martians do it. 👽

@courtneyholcomb courtneyholcomb requested a review from tlento August 29, 2024 20:25
@cla-bot cla-bot bot added the cla:yes label Aug 29, 2024
@dbt-labs dbt-labs deleted a comment from github-actions bot Aug 29, 2024
@courtneyholcomb courtneyholcomb added the Reload Test Data in SQL Engines Should be run when test data changes label Aug 29, 2024
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS August 29, 2024 23:30 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS August 29, 2024 23:30 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS August 29, 2024 23:30 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS August 29, 2024 23:30 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Reload Test Data in SQL Engines Should be run when test data changes label Aug 29, 2024
@tlento tlento added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Sep 9, 2024
@tlento tlento had a problem deploying to DW_INTEGRATION_TESTS September 9, 2024 05:38 — with GitHub Actions Failure
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS September 9, 2024 05:38 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS September 9, 2024 05:38 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS September 9, 2024 05:38 — with GitHub Actions Inactive
tlento
tlento approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good but BigQuery is freaking out about tables not existing here and upstack even though you clearly created them. I'll keep poking away at the labels for a bit longer, see if I can get this sorted out.

@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Sep 9, 2024
@tlento tlento added the Reload Test Data in SQL Engines Should be run when test data changes label Sep 9, 2024
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS September 9, 2024 05:57 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS September 9, 2024 05:57 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS September 9, 2024 05:57 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS September 9, 2024 05:57 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Reload Test Data in SQL Engines Should be run when test data changes label Sep 9, 2024
@tlento tlento added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Sep 9, 2024
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS September 9, 2024 06:03 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS September 9, 2024 06:03 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS September 9, 2024 06:03 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS September 9, 2024 06:03 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Sep 9, 2024
@tlento
Copy link
Contributor

tlento commented Sep 9, 2024

mood rn:

it crowd

Reloading the data apparently worked just fine!

@courtneyholcomb courtneyholcomb merged commit b8e3e3a into main Sep 10, 2024
55 of 57 checks passed
@courtneyholcomb courtneyholcomb deleted the court/custom-grain branch September 10, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlento tlento tlento approved these changes

Assignees
No one assigned
Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@courtneyholcomb @tlento