DataflowPlan for custom granularities
#1382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
changed the title
courtneyholcomb
changed the title
DataflowPlan for custom granularities
This is blocked by updates to the TimeDimensionSpec, so currently it won't ever get hit. Will update when unblocked.
courtneyholcomb
force-pushed
the
court/custom-grain-dfp
branch
from
5e5315c to
6216f91
Compare
…spine_sources() This will help differentiate from a new method that builds custom time spine sources
WIP - uses some hard-coded names and includes some TODOs
courtneyholcomb
force-pushed
the
court/custom-grain-dfp
branch
from
fcd3c22 to
46a3d5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
JoinToCustomGranularityNodeto the dataflow plan. This will enable using custom granularities in queries.Notes:
TimeDimensionSpecsso that should be updated before merging.TimeDimensionSpecs.