Update aggregated conversion node to only have queried linkable specs #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
|
Sweet! Can we add a test? |
Oh ya i was just wondering if this looked good first! |
WilliamDee
force-pushed
the
will/fix-extra-linkable-specs
branch
from
a0a64d8 to
3cddd91
Compare
WilliamDee
force-pushed
the
will/fix-extra-linkable-specs
branch
from
3cddd91 to
961db61
Compare
tlento
reviewed
Aug 23, 2024
WilliamDee
force-pushed
the
will/fix-extra-linkable-specs
branch
from
961db61 to
93e0407
Compare
WilliamDee
force-pushed
the
will/fix-extra-linkable-specs
branch
from
93e0407 to
98d16f5
Compare
WilliamDee
force-pushed
the
will/fix-extra-linkable-specs
branch
from
98d16f5 to
7aa19d7
Compare
WilliamDee
force-pushed
the
will/fix-extra-linkable-specs
branch
from
03347c5 to
29e2ab6
Compare
courtneyholcomb
approved these changes
Oct 24, 2024
WilliamDee
added
the
Run Tests With Other SQL Engines
WilliamDee
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
WilliamDee
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
WilliamDee
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
WilliamDee
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When you try to query a conversion metric by supplying a filter with a dimension that exists in the base measure's semantic model without providing it in the group by, the rendering fails. This is because with the logic in the conversion metric builder, it ended up "requiring" all the linkable specs from the query (group by + filter), so the group by provided in the filter gets added to the resulting
SELECTeven though it was not supplied in the group by. This caused an error with the join as it didn't expect that additional element. This PR updates it so that instead of using all the required linkable specs, we should only use the queried linkable specs when building out the conversion aggregate node.Resolves #1210
Resolves SL-2777