Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log for better debugging #1376

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Improve log for better debugging #1376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion metricflow/plan_conversion/dataflow_to_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,10 @@ def visit_combine_aggregated_outputs_node(self, node: CombineAggregatedOutputsNo
linkable_specs = from_data_set.data_set.instance_set.spec_set.linkable_specs
assert all(
[set(x.data_set.instance_set.spec_set.linkable_specs) == set(linkable_specs) for x in join_data_sets]
), "All parent nodes should have the same set of linkable instances since all values are coalesced."
), (
"All join data sets should have the same set of linkable instances as the from dataset since all values are coalesced. "
f"Got from dataset: {from_data_set}\nGot join datasets: {join_data_sets}"
)

linkable_spec_set = from_data_set.data_set.instance_set.spec_set.transform(SelectOnlyLinkableSpecs())
join_type = SqlJoinType.CROSS_JOIN if len(linkable_spec_set.all_specs) == 0 else SqlJoinType.FULL_OUTER
Expand Down
Loading