Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom_granularity_columns to TimeSpineSource #1373

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

courtneyholcomb
Copy link
Contributor

Completes SL-2744

Add custom_granularity_columns to TimeSpineSource. Along the way:

  • Bumped DSI version to get the new spec that includes custom granularities. Updated this in both MF and metricflow-semantics, since the spec was needed in both places. Now that mantle points to an older commit of MF, it should be fine to use a dev version here for now. We'll just need to update to a non-dev version if we ever need to update the commit that mantle is using.
  • Updated the commit of dbt-core that we use for tests. This was needed to enable compatibility with DSI 0.7.0.
  • Renamed old attributes that weren't specific enough to differentiate them from the new attributes.

Also removes the comment about needing a production version in metricflow-semantics. Now that core points to a commit of metricflow-semantics, this shouldn't matter.
@courtneyholcomb courtneyholcomb requested a review from tlento August 21, 2024 00:12
Copy link

linear bot commented Aug 21, 2024

Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable at a glance but I'd like to come back to it after I make a bit more progress with the container object for managing custom granularities.

@courtneyholcomb
Copy link
Contributor Author

This seems reasonable at a glance but I'd like to come back to it after I make a bit more progress with the container object for managing custom granularities.

@tlento any thoughts on merging this yet? Seems easy enough to change later!

Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable!

@courtneyholcomb courtneyholcomb merged commit 02adf76 into main Aug 28, 2024
41 of 43 checks passed
@courtneyholcomb courtneyholcomb deleted the court/ts-custom branch August 28, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants