Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded TODO #1371

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Remove unneeded TODO #1371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion metricflow/plan_conversion/dataflow_to_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,6 @@ def _choose_time_spine_source(
]
if not compatible_time_spine_grains:
raise RuntimeError(
# TODO: update docs link when new docs are available
f"This query requires a time spine with granularity {smallest_agg_time_grain.name} or smaller, which is not configured. "
f"The smallest available time spine granularity is {min(self._time_spine_sources.keys()).name}, which is too large."
"See documentation for how to configure a new time spine: https://docs.getdbt.com/docs/build/metricflow-time-spine"
Expand Down
Loading