-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for metrics that require time spine with sub-daily granularity #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
changed the title
Court/subd metrics 2
Tests for metrics that require time spine with sub-daily granularity
Jul 30, 2024
courtneyholcomb
force-pushed
the
court/subd-metrics-2
branch
from
July 30, 2024 00:15
209e69e
to
d96a9c1
Compare
courtneyholcomb
force-pushed
the
court/subd-metrics-2
branch
4 times, most recently
from
July 30, 2024 00:55
4e01f86
to
857a942
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Jul 30, 2024
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
July 30, 2024 00:55 — with
GitHub Actions
Failure
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
July 30, 2024 00:55 — with
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
July 30, 2024 00:55 — with
GitHub Actions
Inactive
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
July 30, 2024 00:55 — with
GitHub Actions
Failure
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Jul 30, 2024
courtneyholcomb
added
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Jul 30, 2024
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
July 30, 2024 01:01 — with
GitHub Actions
Failure
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
July 30, 2024 01:01 — with
GitHub Actions
Failure
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
July 30, 2024 01:01 — with
GitHub Actions
Failure
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
July 30, 2024 01:01 — with
GitHub Actions
Failure
courtneyholcomb
force-pushed
the
court/subd-metrics-2
branch
from
July 30, 2024 01:05
bfd90c5
to
4926f24
Compare
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Jul 30, 2024
courtneyholcomb
added
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Jul 30, 2024
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
July 30, 2024 01:08 — with
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
July 30, 2024 01:08 — with
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
July 30, 2024 01:08 — with
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
July 30, 2024 01:08 — with
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Jul 30, 2024
courtneyholcomb
force-pushed
the
court/subd-metrics
branch
from
July 30, 2024 21:16
cf47d11
to
044c898
Compare
courtneyholcomb
force-pushed
the
court/subd-metrics-2
branch
from
July 30, 2024 21:17
4926f24
to
4199ee7
Compare
…with sub-daily granularities
courtneyholcomb
force-pushed
the
court/subd-metrics-2
branch
from
July 30, 2024 22:50
4199ee7
to
1066f75
Compare
tlento
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GROUP BY subq_3.ts | ||
--- | ||
integration_test: | ||
name: subdaily_cumulative_grain_to_date_metric |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooo, I need to make sure we can do grain to date with custom granularities...... duly noted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More tests. Specifically covering metrics that require the time spine. Types covered: