Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for metrics that require time spine with sub-daily granularity #1361

Merged
merged 7 commits into from
Jul 31, 2024

Conversation

courtneyholcomb
Copy link
Contributor

@courtneyholcomb courtneyholcomb commented Jul 29, 2024

More tests. Specifically covering metrics that require the time spine. Types covered:

  • Cumulative metrics
  • Offset metrics
  • Join to time spine metrics

@cla-bot cla-bot bot added the cla:yes label Jul 29, 2024
@courtneyholcomb courtneyholcomb changed the base branch from main to court/subd-metrics July 30, 2024 00:15
@courtneyholcomb courtneyholcomb changed the title Court/subd metrics 2 Tests for metrics that require time spine with sub-daily granularity Jul 30, 2024
@courtneyholcomb courtneyholcomb force-pushed the court/subd-metrics-2 branch 4 times, most recently from 4e01f86 to 857a942 Compare July 30, 2024 00:55
@dbt-labs dbt-labs deleted a comment from github-actions bot Jul 30, 2024
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jul 30, 2024
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS July 30, 2024 00:55 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS July 30, 2024 00:55 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb marked this pull request as ready for review July 30, 2024 00:57
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jul 30, 2024
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jul 30, 2024
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jul 30, 2024
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jul 30, 2024
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS July 30, 2024 01:08 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS July 30, 2024 01:08 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS July 30, 2024 01:08 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS July 30, 2024 01:08 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jul 30, 2024
Base automatically changed from court/subd-metrics to main July 30, 2024 22:48
Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

GROUP BY subq_3.ts
---
integration_test:
name: subdaily_cumulative_grain_to_date_metric
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooo, I need to make sure we can do grain to date with custom granularities...... duly noted.

@courtneyholcomb courtneyholcomb merged commit b9195a6 into main Jul 31, 2024
15 checks passed
@courtneyholcomb courtneyholcomb deleted the court/subd-metrics-2 branch July 31, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants