Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for simple metrics with sub-daily dimensions #1360

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Tests for simple metrics with sub-daily dimensions #1360

merged 3 commits into from
Jul 30, 2024

Conversation

courtneyholcomb
Copy link
Contributor

@courtneyholcomb courtneyholcomb commented Jul 29, 2024 •
edited
Loading

Per title. Just tests!

@cla-bot cla-bot bot added the cla:yes label Jul 29, 2024
@courtneyholcomb courtneyholcomb changed the base branch from main to court/subd-no-metrics July 29, 2024 19:32
@courtneyholcomb courtneyholcomb changed the title Court/subd metrics Tests for simple metrics with sub-daily dimensions Jul 29, 2024
@courtneyholcomb courtneyholcomb added Skip Changelog Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment labels Jul 29, 2024
@courtneyholcomb courtneyholcomb marked this pull request as ready for review July 29, 2024 19:38
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS July 29, 2024 19:38 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS July 29, 2024 19:38 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS July 29, 2024 19:38 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS July 29, 2024 19:38 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jul 29, 2024
@courtneyholcomb courtneyholcomb force-pushed the court/subd-no-metrics branch from b9a0720 to d6d5ef5 Compare July 29, 2024 22:00
@plypaul
Copy link
Contributor

plypaul commented Jul 29, 2024

Seems like it's just the last 3 commits, but can you rebase?

@courtneyholcomb courtneyholcomb force-pushed the court/subd-no-metrics branch 2 times, most recently from 40b1db3 to 2231f38 Compare July 29, 2024 22:30
@courtneyholcomb courtneyholcomb force-pushed the court/subd-metrics branch 2 times, most recently from 318d21b to 5cb2cea Compare July 29, 2024 22:38
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jul 29, 2024
@courtneyholcomb
Copy link
Contributor Author

@plypaul updated, sorry about that!!

@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jul 29, 2024
@courtneyholcomb courtneyholcomb force-pushed the court/subd-no-metrics branch from 2231f38 to 79e46c6 Compare July 29, 2024 22:46
@courtneyholcomb courtneyholcomb force-pushed the court/subd-no-metrics branch 2 times, most recently from d5cff0a to e984404 Compare July 29, 2024 23:30
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jul 29, 2024
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jul 29, 2024
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jul 30, 2024
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS July 30, 2024 00:14 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS July 30, 2024 00:14 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS July 30, 2024 00:14 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS July 30, 2024 00:14 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jul 30, 2024
Base automatically changed from court/subd-no-metrics to court/test-time-spines July 30, 2024 21:02
Base automatically changed from court/test-time-spines to main July 30, 2024 21:06
tlento
tlento approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable for the secondary time dimension scenarios. I assume the metric_time testing is upstack.

@courtneyholcomb
Copy link
Contributor Author

This seems reasonable for the secondary time dimension scenarios. I assume the metric_time testing is upstack.

@tlento it's not. I'll add some more at the top of stack querying with metric_time and the interaction between sub-daily and default granularity.

@courtneyholcomb courtneyholcomb merged commit 4482844 into main Jul 30, 2024
15 checks passed
@courtneyholcomb courtneyholcomb deleted the court/subd-metrics branch July 30, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlento tlento tlento approved these changes

@plypaul plypaul Awaiting requested review from plypaul

Assignees
No one assigned
Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@courtneyholcomb @plypaul @tlento