Backport updates to enable tag-based publishing for dbt-metricflow #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tlento
commented
Jul 27, 2024
tlento
commented
- Enable tag-based deployment for dbt-metricflow (Enable tag-based deployment for dbt-metricflow #1349)
- Remove access token reference for PyPI (Remove access token reference for PyPI #1350)
- Enable Trusted Publishing for PyPI actions
- Fix distribution path for dbt-metricflow
We need to be able to start deploying dbt-metricflow via tags that trigger a deployment action instead of relying on manual deployment. This is necessary for two reasons: 1. The MetricFlow repository is evolving to allow for multiple package deployments in distinctive ways, and each package would benefit from a set of pre-deployment steps. 2. With the CLI now bundled with dbt-metricflow we need a structured way of adding and deploying patch fixes for versions that are too far behind the current repo main branch to deploy off of main. Therefore, this PR splits our PyPI deployment action into two separate versions with different tag-format triggers, one for MetricFlow and the other for dbt-metricflow. Authentication for dbt-metricflow will be managed via PyPI's Trusted Publisher mechanism. MetricFlow will follow suit once the relevant PyPI enrollments are ready. Note these are separate files with some duplication here, but it's minimal, and we expect further divergence over time as we develop package-specific pre-deployment tests for these packages.
We have changed authentication methods for PyPI to a more secure approach, so we no longer have to store an access token in GitHub secrets. This removes the in-code references so we can delete the secrets themselves.
In order to use Trusted Publishing we have to do some special things. Most of these things have been abstracted away through the official action plugin provided by the Python Packaging Authority. This change simply conforms our actions configs with the requirements for the plugin. Specifically, providing the `id-token: write` permission and the target URL for publication in the relevant environment config.
|
The dbt-metricflow configuration also works. See https://github.com/dbt-labs/metricflow/actions/runs/10119840135/job/27988835048 - the file exists error is expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.