Use time spines to determine metric_time grain in no-metric queries & test setup

metricflow-semantics/metricflow_semantics/model/semantics/linkable_spec_resolver.py

@@ -40,6 +40,7 @@
 from metricflow_semantics.model.semantics.linkable_element_set import LinkableElementSet
 from metricflow_semantics.model.semantics.semantic_model_join_evaluator import SemanticModelJoinEvaluator
 from metricflow_semantics.specs.time_dimension_spec import DEFAULT_TIME_GRANULARITY
+from metricflow_semantics.time.time_spine_source import TimeSpineSource
 
 if TYPE_CHECKING:
     from metricflow_semantics.model.semantics.semantic_model_lookup import SemanticModelLookup
@@ -124,6 +125,7 @@ def __init__(
         # Sort semantic models by name for consistency in building derived objects.
         self._semantic_models = sorted(self._semantic_manifest.semantic_models, key=lambda x: x.name)
         self._join_evaluator = SemanticModelJoinEvaluator(semantic_model_lookup)
+        self._time_spine_sources = TimeSpineSource.create_from_manifest(self._semantic_manifest)
 
         assert max_entity_links >= 0
         self._max_entity_links = max_entity_links
@@ -464,7 +466,8 @@ def _get_metric_time_elements(self, measure_reference: Optional[MeasureReference
                 time_dimension_reference=measure_agg_time_dimension_reference,
             )
         else:
-            defined_granularity = DEFAULT_TIME_GRANULARITY
+            # If querying metric_time without metrics, will query from time spines.
+            defined_granularity = min(self._time_spine_sources.keys())
 
         # It's possible to aggregate measures to coarser time granularities (except with cumulative metrics).
         possible_metric_time_granularities = tuple(

metricflow-semantics/metricflow_semantics/test_helpers/metric_time_dimension.py

@@ -9,6 +9,11 @@
 # Shortcuts for referring to the metric time dimension.
 MTD = MetricFlowReservedKeywords.METRIC_TIME.value
 MTD_REFERENCE = TimeDimensionReference(element_name=MetricFlowReservedKeywords.METRIC_TIME.value)
+MTD_SPEC_NANOSECOND = TimeDimensionSpec(
+    element_name=MetricFlowReservedKeywords.METRIC_TIME.value,
+    entity_links=(),
+    time_granularity=TimeGranularity.NANOSECOND,
+)
 MTD_SPEC_DAY = TimeDimensionSpec(
     element_name=MetricFlowReservedKeywords.METRIC_TIME.value, entity_links=(), time_granularity=TimeGranularity.DAY
 )

metricflow-semantics/metricflow_semantics/test_helpers/semantic_manifest_yamls/shared/project_configuration.yaml

@@ -5,3 +5,40 @@ project_configuration:
     - location: $source_schema.mf_time_spine
       column_name: ds
       grain: day
+  time_spines:
+    - node_relation:
+        alias: mf_time_spine_nanosecond
+        schema_name: $source_schema
+      primary_column:
+        name: ts
+        time_granularity: nanosecond
+    - node_relation:
+        alias: mf_time_spine_microsecond
+        schema_name: $source_schema
+      primary_column:
+        name: ts
+        time_granularity: microsecond
+    - node_relation:
+        alias: mf_time_spine_millisecond
+        schema_name: $source_schema
+      primary_column:
+        name: ts
+        time_granularity: millisecond
+    - node_relation:
+        alias: mf_time_spine_second
+        schema_name: $source_schema
+      primary_column:
+        name: ts
+        time_granularity: second
+    - node_relation:
+        alias: mf_time_spine_minute
+        schema_name: $source_schema
+      primary_column:
+        name: ts
+        time_granularity: minute
+    - node_relation:
+        alias: mf_time_spine_hour
+        schema_name: $source_schema
+      primary_column:
+        name: ts
+        time_granularity: hour

metricflow-semantics/metricflow_semantics/test_helpers/semantic_manifest_yamls/simple_manifest/semantic_models/user_sm_source.yaml

@@ -23,6 +23,31 @@ semantic_model:
         time_granularity: day
     - name: home_state
       type: categorical
+    - name: last_hosted_ts
+      type: time
+      type_params:
+        time_granularity: nanosecond
+    - name: last_property_view_ts
+      type: time
+      type_params:
+        time_granularity: microsecond
+    - name: last_profile_edit_ts
+      type: time
+      type_params:
+        time_granularity: millisecond
+    - name: bio_added_ts
+      type: time
+      type_params:
+        time_granularity: second
+    - name: last_login_ts
+      type: time
+      type_params:
+        time_granularity: minute
+    - name: archived_at
+      type: time
+      type_params:
+        time_granularity: hour
+
 
   entities:
     - name: user

metricflow/plan_conversion/time_spine.py → metricflow-semantics/metricflow_semantics/time/time_spine_source.py

@@ -6,9 +6,9 @@
 
 from dbt_semantic_interfaces.protocols import SemanticManifest
 from dbt_semantic_interfaces.type_enums.time_granularity import TimeGranularity
-from metricflow_semantics.specs.time_dimension_spec import DEFAULT_TIME_GRANULARITY
 
-from metricflow.sql.sql_table import SqlTable
+from metricflow_semantics.specs.time_dimension_spec import DEFAULT_TIME_GRANULARITY
+from metricflow_semantics.sql.sql_table import SqlTable
 
 logger = logging.getLogger(__name__)
 
@@ -38,7 +38,7 @@ def create_from_manifest(semantic_manifest: SemanticManifest) -> Dict[TimeGranul
         time_spine_sources = {
             time_spine.primary_column.time_granularity: TimeSpineSource(
                 schema_name=time_spine.node_relation.schema_name,
-                table_name=time_spine.node_relation.relation_name,
+                table_name=time_spine.node_relation.alias,
                 db_name=time_spine.node_relation.database,
                 time_column_name=time_spine.primary_column.name,
                 time_column_granularity=time_spine.primary_column.time_granularity,

metricflow-semantics/tests_metricflow_semantics/query/group_by_item/test_matching_item_for_querying.py

@@ -17,7 +17,7 @@
     MetricGroupByItemResolutionNode,
 )
 from metricflow_semantics.test_helpers.config_helpers import MetricFlowTestConfiguration
-from metricflow_semantics.test_helpers.metric_time_dimension import MTD_SPEC_DAY, MTD_SPEC_MONTH, MTD_SPEC_YEAR
+from metricflow_semantics.test_helpers.metric_time_dimension import MTD_SPEC_MONTH, MTD_SPEC_NANOSECOND, MTD_SPEC_YEAR
 from metricflow_semantics.test_helpers.snapshot_helpers import assert_object_snapshot_equal
 
 from tests_metricflow_semantics.query.group_by_item.conftest import AmbiguousResolutionQueryId
@@ -46,7 +46,7 @@ def test_ambiguous_metric_time_in_query(  # noqa: D103
     )
 
     if case_id is AmbiguousResolutionQueryId.NO_METRICS:
-        assert result.spec == MTD_SPEC_DAY
+        assert result.spec == MTD_SPEC_NANOSECOND
     elif case_id is AmbiguousResolutionQueryId.SIMPLE_METRIC:
         assert result.spec == MTD_SPEC_MONTH
     elif case_id is AmbiguousResolutionQueryId.METRICS_WITH_SAME_TIME_GRAINS:

metricflow-semantics/tests_metricflow_semantics/snapshots/test_available_group_by_items.py/LinkableSpecSet/test_available_group_by_items__no_metrics__set0.txt

@@ -6,13 +6,55 @@
   "TimeDimension('metric_time', 'day', date_part_name='month')",
   "TimeDimension('metric_time', 'day', date_part_name='quarter')",
   "TimeDimension('metric_time', 'day', date_part_name='year')",
+  "TimeDimension('metric_time', 'hour')",
+  "TimeDimension('metric_time', 'hour', date_part_name='day')",
+  "TimeDimension('metric_time', 'hour', date_part_name='dow')",
+  "TimeDimension('metric_time', 'hour', date_part_name='doy')",
+  "TimeDimension('metric_time', 'hour', date_part_name='month')",
+  "TimeDimension('metric_time', 'hour', date_part_name='quarter')",
+  "TimeDimension('metric_time', 'hour', date_part_name='year')",
+  "TimeDimension('metric_time', 'microsecond')",
+  "TimeDimension('metric_time', 'microsecond', date_part_name='day')",
+  "TimeDimension('metric_time', 'microsecond', date_part_name='dow')",
+  "TimeDimension('metric_time', 'microsecond', date_part_name='doy')",
+  "TimeDimension('metric_time', 'microsecond', date_part_name='month')",
+  "TimeDimension('metric_time', 'microsecond', date_part_name='quarter')",
+  "TimeDimension('metric_time', 'microsecond', date_part_name='year')",
+  "TimeDimension('metric_time', 'millisecond')",
+  "TimeDimension('metric_time', 'millisecond', date_part_name='day')",
+  "TimeDimension('metric_time', 'millisecond', date_part_name='dow')",
+  "TimeDimension('metric_time', 'millisecond', date_part_name='doy')",
+  "TimeDimension('metric_time', 'millisecond', date_part_name='month')",
+  "TimeDimension('metric_time', 'millisecond', date_part_name='quarter')",
+  "TimeDimension('metric_time', 'millisecond', date_part_name='year')",
+  "TimeDimension('metric_time', 'minute')",
+  "TimeDimension('metric_time', 'minute', date_part_name='day')",
+  "TimeDimension('metric_time', 'minute', date_part_name='dow')",
+  "TimeDimension('metric_time', 'minute', date_part_name='doy')",
+  "TimeDimension('metric_time', 'minute', date_part_name='month')",
+  "TimeDimension('metric_time', 'minute', date_part_name='quarter')",
+  "TimeDimension('metric_time', 'minute', date_part_name='year')",
   "TimeDimension('metric_time', 'month')",
   "TimeDimension('metric_time', 'month', date_part_name='month')",
   "TimeDimension('metric_time', 'month', date_part_name='quarter')",
   "TimeDimension('metric_time', 'month', date_part_name='year')",
+  "TimeDimension('metric_time', 'nanosecond')",
+  "TimeDimension('metric_time', 'nanosecond', date_part_name='day')",
+  "TimeDimension('metric_time', 'nanosecond', date_part_name='dow')",
+  "TimeDimension('metric_time', 'nanosecond', date_part_name='doy')",
+  "TimeDimension('metric_time', 'nanosecond', date_part_name='month')",
+  "TimeDimension('metric_time', 'nanosecond', date_part_name='quarter')",
+  "TimeDimension('metric_time', 'nanosecond', date_part_name='year')",
   "TimeDimension('metric_time', 'quarter')",
   "TimeDimension('metric_time', 'quarter', date_part_name='quarter')",
   "TimeDimension('metric_time', 'quarter', date_part_name='year')",
+  "TimeDimension('metric_time', 'second')",
+  "TimeDimension('metric_time', 'second', date_part_name='day')",
+  "TimeDimension('metric_time', 'second', date_part_name='dow')",
+  "TimeDimension('metric_time', 'second', date_part_name='doy')",
+  "TimeDimension('metric_time', 'second', date_part_name='month')",
+  "TimeDimension('metric_time', 'second', date_part_name='quarter')",
+  "TimeDimension('metric_time', 'second', date_part_name='year')",
   "TimeDimension('metric_time', 'week')",
   "TimeDimension('metric_time', 'week', date_part_name='month')",
   "TimeDimension('metric_time', 'week', date_part_name='quarter')",