Make pattern classes dataclasses #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tlento
approved these changes
Jul 19, 2024
Comment on lines
+22
to
+23
| def create(listed_specs: Sequence[InstanceSpec]) -> MatchListSpecPattern: # noqa: D102 | ||
| return MatchListSpecPattern(tuple(listed_specs)) |
There was a problem hiding this comment.
Why is this necessary? Just to avoid the callsite typecasting? Might be nice to have a docstring indicating that, but really, since there's exactly one callsite, why not just wrap the argument in that one call in tuple() instead?
There was a problem hiding this comment.
I was in the habit of doing this for some other changes in the stack, but now that you mention it, this one does not need it. Updated.
plypaul
force-pushed
the
p--query-resolution-perf--16
branch
from
8c2baac to
7bf03b5
Compare
|
And I forgot to push those updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes pattern classes dataclass for easier comparison for equality. The comparison is helpful when memoizing / caching function calls.