Handle ambiguous metric_time filters in YAML definitions
#1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/test-dg
branch
from
dbe9a2f to
99d27b0
Compare
courtneyholcomb
changed the title
metric_time filters in YAML definitionsmetric_time filters in YAML definitions
courtneyholcomb
force-pushed
the
court/test-dg
branch
from
5c31d3a to
ab5ba75
Compare
courtneyholcomb
force-pushed
the
court/test-dg
branch
from
ab5ba75 to
33c9852
Compare
plypaul
approved these changes
Jul 19, 2024
| filter: "{{ TimeDimension('metric_time') }} < '2012-12-20'" | ||
| --- | ||
| metric: | ||
| name: bookings_dec_19_2019 |
There was a problem hiding this comment.
Should this be something like bookings_between...? Also feel like there can be a more "friendly" metric that we could create for these tests, but I don't have any good ideas.
There was a problem hiding this comment.
Yeah, it's a weird use case but I figured it's really the SQL that matters here, not the usefulness of the metric. Will update the name!
courtneyholcomb
force-pushed
the
court/test-dg
branch
from
b0f3528 to
25c02ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle ambiguous
metric_timefilters in metric YAML definitions. The expected behavior for an ambiguousmetric_timefilter in a metric's YAML definition is that it will use the default time granularity for the metric where the filter is defined. This means that if a filter is defined on a derived metric's input metric, that filter will use the derived metrics time granularity, not the input metric's time granularity.Aside from that change, this adds tests for other types of ambiguous
metric_timeYAML filters.