Add LinkableElementUnion and use it in WhereFilterSpec
#1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
force-pushed
the
p--query-resolution-perf--10
branch
from
60396be to
5e910ac
Compare
plypaul
force-pushed
the
p--query-resolution-perf--11
branch
from
1fc9566 to
21a7a17
Compare
plypaul
force-pushed
the
p--query-resolution-perf--10
branch
from
5e910ac to
2cba144
Compare
plypaul
force-pushed
the
p--query-resolution-perf--11
branch
from
21a7a17 to
554a820
Compare
plypaul
changed the title
LinkableElement-related classes to use tuplesLinkableElementUnion and use it in WhereFilterSpec
courtneyholcomb
approved these changes
Jul 16, 2024
| linkable_spec_set: LinkableSpecSet | ||
|
|
||
| # def __init__(self, *args, **kwargs): |
There was a problem hiding this comment.
Did you mean to leave this in?
There was a problem hiding this comment.
Good catch - removed.
plypaul
force-pushed
the
p--query-resolution-perf--10
branch
from
2cba144 to
42ea1eb
Compare
plypaul
force-pushed
the
p--query-resolution-perf--11
branch
from
554a820 to
d57898e
Compare
plypaul
force-pushed
the
p--query-resolution-perf--10
branch
from
e71a515 to
9ace719
Compare
plypaul
force-pushed
the
p--query-resolution-perf--11
branch
from
d57898e to
c65a1ea
Compare
plypaul
force-pushed
the
p--query-resolution-perf--11
branch
from
c65a1ea to
f8a2283
Compare
… and use it in `WhereFilterSpec`.
plypaul
force-pushed
the
p--query-resolution-perf--11
branch
from
f8a2283 to
261ab95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of making
WhereFilterSpecserializable, this updates the fieldWhereFilterSpec.linkable_elementsto be a union type that is supported by the serializer.