Set max_metric_default_time_granularity property on PushDownResult
#1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/default-granularity1
branch
from
db76f4a to
30d5b6c
Compare
courtneyholcomb
force-pushed
the
court/default-granularity1
branch
from
30d5b6c to
86f6109
Compare
courtneyholcomb
force-pushed
the
court/default-granularity1.5
branch
from
ca0cf90 to
7ba1065
Compare
plypaul
approved these changes
Jul 13, 2024
plypaul
reviewed
Jul 13, 2024
| # Note: ignores any granularity set on input metrics. | ||
| metric_default_time_granularity = metric.time_granularity or max( | ||
| TimeGranularity.DAY, | ||
| self._semantic_manifest_lookup.metric_lookup.get_min_queryable_time_granularity(node.metric_reference), |
There was a problem hiding this comment.
Double checking that we want the default to be the min. queryable time granularity if it's not set in the configs?
There was a problem hiding this comment.
The product decision was to default to:
DAY, if available (i.e., for dimensions withDAYgranularity or smaller)- Min queryable granularity if
DAYis not available (for dimensions withWEEKgranularity or larger).
And this should implement that behavior! So this won't change the behavior for existing dimensions - will mainly be a change once people start adding sub-daily dimensions.
courtneyholcomb
force-pushed
the
court/default-granularity1.5
branch
from
7ba1065 to
8cdb31f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per title. Set this property when visiting the metric node and narrow down to the max when visiting a query node.