Decouple InstanceSpecSet and LinkableSpecSet
#1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return LinkableSpecSet.create_from_spec_set(InstanceSpecSet.create_from_specs(specs)) | ||
|
|
||
| @dataclass | ||
| class _GroupSpecByTypeVisitor(InstanceSpecVisitor[None]): |
There was a problem hiding this comment.
Curious what it means to have this underscore prefix on a class?
There was a problem hiding this comment.
It indicates more of a "private" class that's not mean to be used elsewhere.
plypaul
force-pushed
the
p--query-resolution-perf--06
branch
from
362b718 to
82e741f
Compare
…_spec_set()` to break circular dependency.
plypaul
force-pushed
the
p--query-resolution-perf--07
branch
from
bd06cc0 to
e9ee66c
Compare
courtneyholcomb
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinkableSpecSetdepends onInstanceSpecSet, which leads to circular dependencies in downstream changes. This PR updates a few methods inLinkableSpecSetto remove that dependency.