Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline LinkableElementProperty.all_properties() #1328

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Jul 11, 2024

This PR updates LinkableElementProperty.all_properties() to iterate over the enum to make it less error prone when new properties are added.

@cla-bot cla-bot bot added the cla:yes label Jul 11, 2024
@plypaul plypaul changed the title Simplify LinkableElementProperty.all_properties() to iterate over enum Streamline LinkableElementProperty.all_properties() Jul 11, 2024
@plypaul plypaul marked this pull request as ready for review July 11, 2024 21:20
Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call 🙏

@plypaul plypaul force-pushed the p--query-resolution-perf--05 branch 3 times, most recently from a2956b0 to 730d87b Compare July 15, 2024 16:35
Base automatically changed from p--query-resolution-perf--05 to main July 15, 2024 16:39
…roperty.all_properties()` to iterate over enum.
@plypaul plypaul force-pushed the p--query-resolution-perf--06 branch from 362b718 to 82e741f Compare July 15, 2024 17:07
@plypaul plypaul enabled auto-merge (squash) July 15, 2024 17:07
@plypaul plypaul merged commit 06b36f5 into main Jul 15, 2024
15 checks passed
@plypaul plypaul deleted the p--query-resolution-perf--06 branch July 15, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants