-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert DAG node classes to dataclasses #1320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
plypaul
force-pushed
the
p--query-resolution-perf--02
branch
from
July 10, 2024 20:48
34df6c4
to
1f72044
Compare
plypaul
force-pushed
the
p--query-resolution-perf--03
branch
from
July 10, 2024 20:48
b68a0fd
to
cf3666e
Compare
plypaul
force-pushed
the
p--query-resolution-perf--03
branch
2 times, most recently
from
July 10, 2024 20:55
2bd689d
to
2164fe0
Compare
plypaul
force-pushed
the
p--query-resolution-perf--03
branch
2 times, most recently
from
July 10, 2024 21:39
53ca214
to
54f7942
Compare
plypaul
changed the title
Convert DAG node classes to be dataclasses
Convert DAG node classes to dataclasses
Jul 10, 2024
courtneyholcomb
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
plypaul
force-pushed
the
p--query-resolution-perf--02
branch
2 times, most recently
from
July 11, 2024 16:59
fbb645c
to
f29f6f6
Compare
plypaul
force-pushed
the
p--query-resolution-perf--03
branch
from
July 11, 2024 17:22
54f7942
to
09049a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create()
method was added to simplify many initialization use cases while not overriding the one generated bydataclasses
.node_id
field is set - please seemf_dag.py
.