Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an interface to override pretty-printing behavior #1319

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Jul 10, 2024

There are some cases when pretty-printing or pretty-formatting an object using MF's pretty-formatter where a different representation is desired e.g. only show specific fields. This PR adds an interface that allows for such control.

Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@plypaul plypaul force-pushed the p--query-resolution-perf--02 branch from 34df6c4 to 1f72044 Compare July 10, 2024 20:48
@plypaul plypaul marked this pull request as ready for review July 10, 2024 20:59


def test_custom_pretty_print() -> None:
"""Check that `MetricFlowPrettyFormatable` can be used to override the result when using MF's pretty-printer."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Formattable*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Base automatically changed from p--query-resolution-perf--01 to main July 11, 2024 16:56
@plypaul plypaul force-pushed the p--query-resolution-perf--02 branch from 1f72044 to fbb645c Compare July 11, 2024 16:57
@plypaul plypaul force-pushed the p--query-resolution-perf--02 branch from fbb645c to f29f6f6 Compare July 11, 2024 16:59
@plypaul plypaul merged commit c484a81 into main Jul 11, 2024
15 checks passed
@plypaul plypaul deleted the p--query-resolution-perf--02 branch July 11, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants