Tests for cumulative metrics queried with non-default granularities #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/test-cumu-grain
branch
4 times, most recently
from
328dfb3 to
2177713
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
courtneyholcomb
force-pushed
the
court/unrestrict-cumu-grain
branch
from
ae72a15 to
0c64b86
Compare
courtneyholcomb
force-pushed
the
court/test-cumu-grain
branch
from
72912f4 to
bb01173
Compare
tlento
approved these changes
Jun 19, 2024
Comment on lines
+515
to
+518
| , FIRST_VALUE(revenue_mtd) OVER ( | ||
| PARTITION BY revenue_instance__ds__quarter, revenue_instance__ds__year | ||
| ORDER BY metric_time__day | ||
| ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING |
There was a problem hiding this comment.
Whoa, all of this works on all engines?
There was a problem hiding this comment.
This SQL rendering logic already existed for conversion metrics, so it should!
There was a problem hiding this comment.
And also SQL engine & check query tests pass, so yes.
| SELECT | ||
| revenue_instance__ds__quarter | ||
| , revenue_instance__ds__year | ||
| , FIRST_VALUE(revenue_mtd) OVER ( |
There was a problem hiding this comment.
Oh this is interesting. If it's month to date and people truncate to year that's super strange, right? It's just always month to date for January or whatever? I guess the answer is "don't do that" - but I do wonder if we should have a different default from FIRST_VALUE - I guess people can eventually override it to LAST_VALUE (which might be more sensible).
courtneyholcomb
force-pushed
the
court/unrestrict-cumu-grain
branch
from
0c64b86 to
568d048
Compare
courtneyholcomb
force-pushed
the
court/test-cumu-grain
branch
from
16093de to
3cd9aa2
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests!!