Remove granularity restriction for cumulative metrics #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/unrestrict-cumu-grain
branch
from
64e46a7 to
ae72a15
Compare
courtneyholcomb
force-pushed
the
court/cumu-grain-dfp
branch
from
ce72cf1 to
02b8f69
Compare
courtneyholcomb
force-pushed
the
court/unrestrict-cumu-grain
branch
from
ae72a15 to
0c64b86
Compare
tlento
approved these changes
Jun 19, 2024
courtneyholcomb
force-pushed
the
court/unrestrict-cumu-grain
branch
from
0c64b86 to
568d048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
BaseTimeGrainPatternfilter that was in place for cumulative metrics. This restricted users from querying cumulative metrics withmetric_timeusing non-default granularities, which will be supported shortly.Also a small cleanup item in related code.
Only thing left in the stack after this is tests!