Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataflowPlan for cumulative metrics queried with non-default granularity #1281

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

courtneyholcomb
Copy link
Contributor

@courtneyholcomb courtneyholcomb commented Jun 14, 2024

When querying cumulative metrics without default granularity, build a dataflow plan that includes WindowReaggregationNode.

E2E tests coming soon for this feature!

@cla-bot cla-bot bot added the cla:yes label Jun 14, 2024
@courtneyholcomb courtneyholcomb changed the title Court/cumu grain dfp DataflowPlan for cumulative metrics queried with non-default granularity Jun 14, 2024
@courtneyholcomb courtneyholcomb changed the title DataflowPlan for cumulative metrics queried with non-default granularity DataflowPlan for cumulative metrics queried with non-default granularity Jun 14, 2024
@dbt-labs dbt-labs deleted a comment from github-actions bot Jun 14, 2024
@courtneyholcomb courtneyholcomb marked this pull request as ready for review June 14, 2024 00:24
@courtneyholcomb courtneyholcomb requested review from tlento and plypaul and removed request for tlento June 14, 2024 00:25
@courtneyholcomb courtneyholcomb force-pushed the court/optimize-window-node branch from 57e5464 to d04d6d3 Compare June 19, 2024 00:02
Base automatically changed from court/optimize-window-node to main June 19, 2024 00:06
Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable!

@courtneyholcomb courtneyholcomb merged commit 91a0b94 into main Jun 19, 2024
15 checks passed
@courtneyholcomb courtneyholcomb deleted the court/cumu-grain-dfp branch June 19, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants