Update optimizer to avoid putting window functions in group by #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlento
approved these changes
Jun 18, 2024
Comment on lines
+295
to
+304
| group_by.column_alias in parent_column_aliases_with_window_functions | ||
| or ( | ||
| group_by.expr.as_column_reference_expression | ||
| and group_by.expr.as_column_reference_expression.col_ref.column_name | ||
| in parent_column_aliases_with_window_functions | ||
| ) | ||
| or ( | ||
| group_by.expr.as_string_expression | ||
| and group_by.expr.as_string_expression.sql_expr in parent_column_aliases_with_window_functions | ||
| ) |
There was a problem hiding this comment.
Oof, why are there so many ways to reference a group by? Oh well. I think I'll blame BigQuery and Trino on general principles.
courtneyholcomb
force-pushed
the
court/window-agg-node
branch
from
a0328b2 to
08fac01
Compare
courtneyholcomb
force-pushed
the
court/optimize-window-node
branch
from
57e5464 to
d04d6d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
WindowAggregationNode, you will end up with a subquery that our currentSqlRewritingSubQueryReducerthinks can be collapsed into the outer query. However, this would put window functions in the group by clause, which triggers a SQL error. This PR updates theSqlRewritingSubQueryReducerlogic to avoid reducing in that circumstance.