Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix funky test #1267

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Fix funky test #1267

merged 2 commits into from
Jun 12, 2024

Conversation

courtneyholcomb
Copy link
Contributor

This test uses a dimension that's not allowed for the metric. Updated here to use the permitted dimension. Not an issue at this point but becomes an issue when working through enabling non-default granularities for cumulative metrics.

@cla-bot cla-bot bot added the cla:yes label Jun 12, 2024
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jun 12, 2024
@courtneyholcomb courtneyholcomb marked this pull request as ready for review June 12, 2024 19:04
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS June 12, 2024 19:04 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS June 12, 2024 19:04 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS June 12, 2024 19:04 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS June 12, 2024 19:04 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jun 12, 2024
Base automatically changed from court/window-funcs to main June 12, 2024 19:13
@courtneyholcomb courtneyholcomb enabled auto-merge (squash) June 12, 2024 19:14
@courtneyholcomb courtneyholcomb merged commit 6aa37c3 into main Jun 12, 2024
15 checks passed
@courtneyholcomb courtneyholcomb deleted the court/fix-funky-test branch June 12, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants