Update SqlWindowFunction enum
#1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
courtneyholcomb
force-pushed
the
court/more-defaults
branch
from
0f3d177 to
33949df
Compare
Add AVERAGE for cumulative metrics with non-default granularities. Remove ROW_NUMBER since it isn't used anywhere. Update values to be uppercase for consistency with our other SQL rendering practices.
courtneyholcomb
force-pushed
the
court/window-funcs
branch
from
26b4e84 to
95db3fa
Compare
WilliamDee
approved these changes
Jun 12, 2024
| FIRST_VALUE = "first_value" | ||
| ROW_NUMBER = "row_number" | ||
| FIRST_VALUE = "FIRST_VALUE" | ||
| LAST_VALUE = "LAST_VALUE" |
There was a problem hiding this comment.
do we need to include this?
There was a problem hiding this comment.
Which part? The uppercasing?
There was a problem hiding this comment.
Oh yes! Sorry forgot to include in the PR description! Will also be used for non-default granularities with cumulative metrics. We could use FIRST_VALUE and order desc, but I decided this was more readable because it aligns with the YAML argument names (which are first/last).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
SqlWindowFunctionenum in a few ways:AVERAGE&LAST_VALUEfor cumulative metrics with non-default granularities.ROW_NUMBERsince it isn't used anywhere.All snapshot updates are just upper-casing from
first_valuetoFIRST_VALUE.