Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default args for unused SqlSelectStatementNode params #1265

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Use default args for unused SqlSelectStatementNode params #1265

merged 1 commit into from
Jun 12, 2024

Conversation

courtneyholcomb
Copy link
Contributor

For the love of code reduction!! Part 2

@courtneyholcomb courtneyholcomb requested a review from tlento June 12, 2024 17:13
@cla-bot cla-bot bot added the cla:yes label Jun 12, 2024
tlento
tlento approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, maybe we should all disable our IDE auto-complete.... nah, that's bananas.

Base automatically changed from court/column-assoc to main June 12, 2024 18:13
@courtneyholcomb courtneyholcomb enabled auto-merge (squash) June 12, 2024 18:15
@courtneyholcomb courtneyholcomb merged commit c04f343 into main Jun 12, 2024
15 checks passed
@courtneyholcomb courtneyholcomb deleted the court/more-defaults branch June 12, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlento tlento tlento approved these changes

Assignees
No one assigned
Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@courtneyholcomb @tlento