Remove SQLAlchemy dependency
#1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
added
Run Tests With Other SQL Engines
plypaul
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
plypaul
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
plypaul
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
plypaul
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
plypaul
added
Run Tests With Other SQL Engines
plypaul
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
plypaul
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
plypaul
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
plypaul
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
plypaul
added
Run Tests With Other SQL Engines
plypaul
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
added
Run Tests With Other SQL Engines
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
tlento
approved these changes
Jun 6, 2024
| """Populates default env var mapping from a sqlalchemy URL string. | ||
|
|
||
| This is used to configure the test environment from the original MF_SQL_ENGINE_URL environment variable in | ||
| a manner compatible with the dbt profile configurations laid out for most supported engines. We return | ||
| the parsed URL object so that individual engine configurations can override the environment variables | ||
| as needed to match their dbt profile configuration. | ||
| """ | ||
| parsed_url = sqlalchemy.engine.make_url(url) | ||
| # parsed_url = sqlalchemy.engine.make_url(url) |
|
|
||
| * This implementation is used to avoid having to specify SQLAlchemy as a dependency. | ||
| * Databricks has a URL with a semicolon that separates an additional parameter. e.g. | ||
| `databricks://host:port/database;http_path=a/b/c`. Need additional context for why this is done. |
There was a problem hiding this comment.
Our original Databricks client was built before they added an officially supported SQLAlchemy client, so we used the JDBC connection URI. https://docs.databricks.com/en/integrations/jdbc/authentication.html
| * Databricks has a URL with a semicolon that separates an additional parameter. e.g. | ||
| `databricks://host:port/database;http_path=a/b/c`. Need additional context for why this is done. | ||
| """ | ||
| url_seperator = ";" |
There was a problem hiding this comment.
nit:
Suggested change
| url_seperator = ";" | |
| url_separator = ";" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
SQLAlchemydependency is only needed because we need to parse the URL for the SQL engine configuration. Since it's relatively straightforward to parse, this PR uses built-inurllibto do the parsing and removes theSQLAlchemydependency.