Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inference module #1245

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Remove inference module #1245

merged 3 commits into from
Jun 5, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Jun 4, 2024

Description

This removes the inference module as it is no longer relevant since metricflow uses dbt models.

@cla-bot cla-bot bot added the cla:yes label Jun 4, 2024
@plypaul plypaul marked this pull request as ready for review June 4, 2024 22:43
Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raccoon_sweeping

@@ -34,7 +34,6 @@ dependencies = [
"pydantic>=1.10.0, <1.11.0",
"python-dateutil>=2.8.2, <2.9.0",
"rapidfuzz>=3.0, <4.0",
"ruamel.yaml>=0.17.21, <0.18.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, that's all we were using this for? Nice!

I'm pretty sure there's some special casing around this package in our mypy.ini, but I don't know if we can actually remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - updated mypy.ini.

@tlento tlento changed the title Remove inference modulle Remove inference module Jun 5, 2024
@plypaul plypaul force-pushed the p--py312--10 branch 2 times, most recently from 01dc251 to 2bd682c Compare June 5, 2024 01:14
Base automatically changed from p--py312--10 to main June 5, 2024 22:40
@plypaul plypaul enabled auto-merge (squash) June 5, 2024 22:47
@plypaul plypaul merged commit e599bd0 into main Jun 5, 2024
15 checks passed
@plypaul plypaul deleted the p--py312--11 branch June 5, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants