Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pandas time-period calls to an interface #1232

Merged
merged 2 commits into from
May 31, 2024
Merged

Move pandas time-period calls to an interface #1232

merged 2 commits into from
May 31, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented May 30, 2024

Description

This PR moves time-adjustment operations into a interface / class so that
uses of pandas for this purpose can be encapsulated. This will facilitate
the switch from pandas to dateutil for these time-related operations.

plypaul added 2 commits May 29, 2024 18:41
…terface.

This PR moves time-adjustment operations into a interface / class so that
uses of `pandas` for this purpose can be encapsulated. This will facilitate
the switch from `pandas` to `dateutil` for these time-related operations.
These will be removed later, but moving them to a single file will make that
cleaner.
@plypaul plypaul changed the title Move pandas / time-period calls to an interface Move pandas time-period calls to an interface May 30, 2024
@plypaul plypaul marked this pull request as ready for review May 30, 2024 01:51
Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable given the dateutil-based implementation upstack.

@plypaul plypaul merged commit 853e079 into main May 31, 2024
16 checks passed
@plypaul plypaul deleted the p--py312--01 branch May 31, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants