Add logging to track latency for metrics as dimensions in query parsing #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
requested review from
tlento,
plypaul,
DevonFulcher and
WilliamDee
DevonFulcher
approved these changes
May 21, 2024
@DevonFulcher not exactly my area of expertise, but it's my understanding that we can't do the same type of tracing in MF that we do in MFS since it's a third party package 🤔 |
aiguofer
reviewed
May 22, 2024
| linkable_element_sets_for_no_metrics_queries.append( | ||
| self.get_joinable_metrics_for_semantic_model( | ||
| semantic_model, SemanticModelJoinPath(left_semantic_model_reference=semantic_model.reference) | ||
| ) | ||
| ) | ||
| logger.info(f"Building valid linkable metrics took: {time.time() - linkable_metrics_start_time:.2f}s") |
There was a problem hiding this comment.
:( we need to figure out how to add stuff to extra in MF logs.... having it as a field in DD would allow us to easily calculate all sorts of stats on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logging to see if metrics as dimensions is causing major slowdowns.