Appropriate handling for group by source nodes in ComputeMetricsBranchCombiner
#1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/ratio-bug
branch
from
8339618 to
08bf20f
Compare
courtneyholcomb
changed the title
for_group_by_source_node arg
courtneyholcomb
force-pushed
the
court/ratio-bug
branch
from
08bf20f to
0ba000a
Compare
courtneyholcomb
changed the title
ComputeMetricsBranchCombiner
courtneyholcomb
force-pushed
the
court/ratio-bug
branch
4 times, most recently
from
22f6a35 to
5357c8e
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
courtneyholcomb
force-pushed
the
court/ratio-bug
branch
from
286da20 to
3d94c39
Compare
This test case demonstrates the bug, as you can see in CI failures for this commit. This error is only triggered in e2e tests where we ensure the ComputeMetricsBranchCombiner is used.
courtneyholcomb
force-pushed
the
court/ratio-bug
branch
from
3d94c39 to
94248e7
Compare
courtneyholcomb
added
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
plypaul
reviewed
May 15, 2024
| @@ -293,6 +293,14 @@ def visit_compute_metrics_node(self, node: ComputeMetricsNode) -> ComputeMetrics | |||
| ) | |||
| return ComputeMetricsBranchCombinerResult() | |||
|
|
|||
| if self._current_left_node.for_group_by_source_node != current_right_node.for_group_by_source_node: | |||
There was a problem hiding this comment.
Can you move this check (and the above aggregated_to_elements check) to a method in ComputeMetricsNode similar to:
def combine(self, other: ComputeMetricsNode) -> CombinationResult
...
That should make it easier update that node in the future.
There was a problem hiding this comment.
Might be easier to do can_combine instead for now.
plypaul
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jordan found a bug when using metric filters on ratio metrics in prod. The error indicates that a
ComputeMetricsNodeis being unexpectedly created withMetricSpecsinstead ofGroupByMetricSpecs.I was able to reproduce the error in check query tests. You can see the test case & the CI failures in the first commit here. To fix that bug, I updated the
ComputeMetricsBranchCombinerto use theComputeMetricsNode.for_group_by_source_nodeparam where missed. I also added a step to ensure we don't combine nodes if only one is a group by source node (since that needs to be aggregated separately before joining to the outer query).