Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for metric filters with inner-query joins #1208

Merged
merged 8 commits into from
May 17, 2024
Merged

Tests for metric filters with inner-query joins #1208

merged 8 commits into from
May 17, 2024

Conversation

courtneyholcomb
Copy link
Contributor

Description

Add tests for metric filters where the metric subquery has one or two joins.

@courtneyholcomb courtneyholcomb requested review from tlento and plypaul May 11, 2024 16:49
@cla-bot cla-bot bot added the cla:yes label May 11, 2024
@dbt-labs dbt-labs deleted a comment from github-actions bot May 11, 2024
@courtneyholcomb courtneyholcomb added Reload Test Data in SQL Engines Should be run when test data changes Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment labels May 13, 2024
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 13, 2024 15:13 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 13, 2024 15:13 — with GitHub Actions Inactive
@tlento tlento added Reload Test Data in SQL Engines Should be run when test data changes Skip Changelog and removed Reload Test Data in SQL Engines Should be run when test data changes Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment Skip Changelog labels May 16, 2024
tlento
tlento approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge conflicts are going to cause other lint errors. Sorry about the delays on that, totally missed this PR.

Please make sure all engine tests are passing before merge! If you add the persist and run tests labels at the same time I think the second one clobbers the first and then everything will fail, so it might be a little annoying.

tests_metricflow/query_rendering/test_metric_filter_rendering.py
Comment on lines +348 to +352
query_spec = multihop_query_parser.parse_and_validate_query(
metric_names=("third_hop_count",),
where_constraint=PydanticWhereFilter(
where_sql_template="{{ Metric('txn_count', ['account_id__customer_id__customer_third_hop_id']) }} > 2",
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

@courtneyholcomb courtneyholcomb added the Reload Test Data in SQL Engines Should be run when test data changes label May 17, 2024
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 17, 2024 00:45 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 17, 2024 00:45 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 17, 2024 00:45 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 17, 2024 00:45 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Reload Test Data in SQL Engines Should be run when test data changes label May 17, 2024
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label May 17, 2024
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 17, 2024 01:05 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 17, 2024 01:05 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 17, 2024 01:05 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb added Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment and removed Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment labels May 17, 2024
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 17, 2024 01:32 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 17, 2024 01:32 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 17, 2024 01:32 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 17, 2024 01:32 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label May 17, 2024
@courtneyholcomb courtneyholcomb merged commit 279414e into main May 17, 2024
30 checks passed
@courtneyholcomb courtneyholcomb deleted the court/test-multi-hop-inner branch May 17, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlento tlento tlento approved these changes

@plypaul plypaul Awaiting requested review from plypaul

Assignees
No one assigned
Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@courtneyholcomb @tlento