Query suggestions for GroupByMetrics
#1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pattern was filtering out group by metrics unintentionally.
courtneyholcomb
force-pushed
the
court/gbm-validations
branch
from
2952cf5 to
a9a07e5
Compare
courtneyholcomb
changed the title
courtneyholcomb
changed the title
GroupByMetrics
courtneyholcomb
force-pushed
the
court/gbm-validations
branch
from
a9a07e5 to
db4bd40
Compare
Currently, metric filters have a parameter that's not captured in their input string (the outer query entity links). This means that you might end up with multiple input strings that look the same, so we need to dedupe those. These duplicates will look different once we add a new parameter to metric filters that allows users to specify the outer entity links. But there should be no harm in using a set here, either way.
courtneyholcomb
force-pushed
the
court/gbm-validations
branch
4 times, most recently
from
9a74140 to
223b0c1
Compare
GroupByMetrics are allowed in filters, but not in group by items. Use new pattern to distinguish the two.
…results You'll notice some of the snapshots here have changed. The fuzzy match scores for these items have not changed. What changed was the order of candidate items passed into the similarity scorer once group by metrics were added to the list of candidate items. The change in order for these snapshots is due to ties in score that are returned in the order they came in. Sort inputs to ensure consistent results in the future.
courtneyholcomb
force-pushed
the
court/gbm-validations
branch
from
223b0c1 to
fd3657e
Compare
tlento
approved these changes
May 13, 2024
| """Tests that a query for an invalid group by metric gives an appropriate group by metric suggestion.""" | ||
| with pytest.raises(InvalidQueryException, match="Metric\\('bookings', group_by=\\['listing'\\]\\)"): | ||
| bookings_query_parser.parse_and_validate_query( | ||
| metric_names=("bookings",), where_constraint_str="{{ Metric('listings', ['garbage']) }} > 1" |
There was a problem hiding this comment.
LOL. Where's the Oscar the Grouch garbage can emoji when I need one...
| @@ -6,7 +6,7 @@ Error #1: | |||
| The given input does not exactly match any known metrics. | |||
|
|
|||
| Suggestions: | |||
| ['bookings', 'booking_fees', 'booking_value', 'instant_bookings', 'booking_payments', 'max_booking_value'] | |||
| ['bookings', 'booking_fees', 'booking_value', 'booking_payments', 'instant_bookings', 'booking_value_p99'] | |||
There was a problem hiding this comment.
So max_booking_value was tied with booking_value_p99 here and the sort pushed the latter into 6th place?
There was a problem hiding this comment.
Well it's actually like a 7-way tie between a bunch of metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables suggestions for
GroupByMetrics. This just means that, if you query an invalid group by metric, the suggestion generator will show you valid group by metrics to help you figure out the right filter.More detail is provided in commit messages / commit descriptions.