Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test rendering for conversion metric filter #1195

Merged
merged 2 commits into from
May 10, 2024

Conversation

courtneyholcomb
Copy link
Contributor

Description

Rendering test for a conversion metric filter.
I intended to add a check query test, too, but the SQL result turned out so complicated that it didn't seem particularly useful.

@courtneyholcomb courtneyholcomb requested review from tlento and plypaul May 9, 2024 00:01
@cla-bot cla-bot bot added the cla:yes label May 9, 2024
@courtneyholcomb courtneyholcomb force-pushed the court/gb-metric-test4 branch from fab089a to cbc8d31 Compare May 9, 2024 00:03
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label May 9, 2024
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 9, 2024 18:33 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 9, 2024 18:33 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 9, 2024 18:33 — with GitHub Actions Inactive
@courtneyholcomb courtneyholcomb temporarily deployed to DW_INTEGRATION_TESTS May 9, 2024 18:33 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label May 9, 2024
@tlento
Copy link
Contributor

tlento commented May 10, 2024

I intended to add a check query test, too, but the SQL result turned out so complicated that it didn't seem particularly useful.

Yeah, for conversion metrics I think we need to do output checks - it's often easier, with a simple example, to do the math than it is to figure out how to write the SQL.

Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot. Conversion metrics are so incredibly complicated.....

@courtneyholcomb courtneyholcomb force-pushed the court/gb-metric-test3 branch from 87efcdd to d940abd Compare May 10, 2024 17:35
Base automatically changed from court/gb-metric-test3 to main May 10, 2024 17:39
@courtneyholcomb courtneyholcomb force-pushed the court/gb-metric-test4 branch from 11a50f1 to 0dc7eef Compare May 10, 2024 17:42
@courtneyholcomb courtneyholcomb enabled auto-merge (squash) May 10, 2024 17:42
@courtneyholcomb courtneyholcomb merged commit 3be09af into main May 10, 2024
15 checks passed
@courtneyholcomb courtneyholcomb deleted the court/gb-metric-test4 branch May 10, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants