Remove pandas / numpy Dependency From metricflow
#1190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
plypaul
force-pushed
the
p-rm-pandas--03
branch
6 times, most recently
from
a053545 to
3840339
Compare
|
Closing this out as this was significantly revised, and related changes will be in a another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
pandas/numpyfrommetricflowfor similar reasons as those listed in #1189.The main challenge with doing so is that the
DataFrameimplementation needs to be swapped. The operations that are done withDataFramesare limited to access, comparison, and display operations, so an internal representation is reasonable.Cleanup is still remaining:
MetricFlowDataTableneeds refinement e.g. type-casting / inference of data types / logic consolidation.