Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure snapshot directory in SnapshotConfiguration #1186

Merged
merged 1 commit into from
May 8, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented May 8, 2024

Description

Instead of searching the directory hierarchy of the test file to locate the snapshot directory, this PR uses a directory anchor to configure the snapshot directory.

Instead of searching the directory hierarchy of the test file to locate the
snapshot directory, this PR uses a directory anchor to configure the snapshot
directory.
@cla-bot cla-bot bot added the cla:yes label May 8, 2024
@plypaul plypaul marked this pull request as ready for review May 8, 2024 00:08
Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@plypaul plypaul merged commit e1bed00 into main May 8, 2024
43 checks passed
@plypaul plypaul deleted the plypaul--17--configure-snapshot-dir branch May 8, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants