Temporarily disable multi-hop LinkableMetrics
#1181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are joined, so they should semantically belong here.
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
courtneyholcomb
force-pushed
the
court/gb-metrics1
branch
2 times, most recently
from
4f6bbcd to
095a863
Compare
courtneyholcomb
changed the title
LinkableMetrics
courtneyholcomb
force-pushed
the
court/gb-metrics1
branch
from
10e53ea to
d2bee54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes options for multi-hop
LinkableMetricsfrom theLinkableSpecResolver. That includes multi-hop for both the inner and outer queries. This is only temporary, so I tried to do it with the minimum code possible (while preserving all the logic we'll need to enable multi-hop soon).Note: for some of the inner queries in snapshots, you'll still see two entity links. That's still single-hop. One entity would indicate that the entity is local to the metric's source semantic model, while two indicates a single-hop join.