Test that all available single-hop metrics don't error #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Best PR description opening ever. 🤣 |
courtneyholcomb
force-pushed
the
court/gb-metrics15
branch
from
4496bc6 to
21d9a88
Compare
courtneyholcomb
force-pushed
the
court/gb-metrics16
branch
from
b3d8316 to
b640ed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test that these things actually work! This test loops through the allowed linkable metrics and runs them through the query parser & dataflow plan builder. This ensures that they will work for both group by resolution logic and dataflow plan logic.
More tests to come: