Reorganize linkable spec modules #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 23, 2024
The linkable_spec_resolver module is quite unwieldy with all of these type-spec dataclasses inlined with the resolver itself. Historically, this made sense, because these classes were generally not used outside of contexts where we'd need the resolver itself. However, predicate pushdown will change this calculus, as the classes in the new linkable_elements module are the least objectionable way of propagating resolution-time metadata into the DataflowPlanBuilder. Splitting these out proactively helps us avoid inevitable circular dependencies in the runtime components when we start moving the metadata these classes represent across that boundary.
Now that we have a module for enumerations and dataclass type definitions we might as well consolidate.
This is now being returned through methods in the MetricLookup, which means it can be used independently of the LinkableSpecResolver. As such it merits its own module. This will also be useful for the short term need to access this class in the predicate pushdown implementation, and longer term might make it easier to consolidate this class with the LinkableSpecSet.
tlento
force-pushed
the
reorganize-linkable-spec-modules
branch
from
0ba2a01 to
aaca4b7
Compare
plypaul
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of this moment the LinkableSpecResolver drives our group by resolution, and
the LinkableElementSet is the least objectionable way to move group by
resolution information across the boundary between the resolver and the
DataflowPlanBuilder. Doing so will eventually require us to be able to operate
on LinkableSpecs and LinkableElements in interchangeable ways.
This PR breaks up the cumbersome linkable_spec_resolver module into components
consisting of a type specification module (which also subsumes the separate
module for LinkableElementProperties), a module for the LinkableElementSet,
and the original module which still contains the resolver itself. This makes
it possible to unify LinkableElements and ElementPathKeys with LinkableSpecs
in a step-wise manner without introducing circular dependencies.